Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to show deprecated concepts / skosmos:showDeprecated #653

Merged
merged 4 commits into from
Nov 8, 2017

Conversation

tfrancart
Copy link
Contributor

In some situations we would like to show deprecated concepts in the interface :

  • in alphabetical listings
  • when searching
  • when listing concepts in a group

We have added a "skosmos:showDeprecated" configuration property in vocabularies.ttl that drives whether the FILTER NOT EXISTS { ?s owl:deprecated true } clause is inserted in the SPARQL queries. The default is always to hide deprecated concepts.

Unit tests are included.

@osma
Copy link
Member

osma commented Nov 6, 2017

Thanks for the PR. We will consider this. It needs documentation in the wiki, but that should be easy.

However, the tests fail on Travis with this error:

Trying to @cover or @use not existing method "VocabularyConfig::showDeprecated".

I think it should be getShowDeprecated to match the code.

@osma osma added this to the 1.10 milestone Nov 7, 2017
@osma
Copy link
Member

osma commented Nov 7, 2017

Looks good to me. @henriyli want to take a look?

@osma osma requested a review from henriyli November 7, 2017 08:50
Copy link
Collaborator

@henriyli henriyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@henriyli henriyli merged commit 42b01ec into NatLibFi:master Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants