-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SKOS relations to JSON-LD serialization #748
Conversation
5f99618
to
3fb6d25
Compare
Ouch indeed! Thanks for spotting! A failing test is a great way to report an issue :) The proposed solution sounds good. I think this will only affect |
3fb6d25
to
2bb3dad
Compare
2bb3dad
to
c764b3d
Compare
Ok, added the mapping relations to the context for the I also wanted the output from the |
c764b3d
to
2c245b0
Compare
If additional fields are requested using the 'fields' parameter, add them to the JSON-LD context. Note: This will break any implementation that relies on the 'skos:' prefix being part of the keys.
2c245b0
to
1a5cc6c
Compare
Excellent work! I see you even added a RestControllerTest class, which we didn't have before. The only problem I see is that the Travis tests failed due to an unrelated PHP version compatibility issue. That should be fixed in master now. I will try merging this first into a separate branch to make sure it doesn't actually break the tests. |
Tests OK after merge. Thanks a lot! |
Realized earlier today that
skos:relatedMatch
is returned asrelated:Match
in the JSON-LD serialization.. example 🌵 Ouch!As a start, I added a failing test case to document it.
I think the easiest fix is to add the various SKOS mapping properties (exactMatch, closematch, etc.) to the default JSON-LD context). Let me know what you think.