Fix "Any language" label not showing in edge case #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an edge cases where the label "Any language" on the search bar language selection button shows as "Undefined" when the UI language is not a valid search language and no vocabulary has been selected.
danmichaelo
force-pushed
the
fix-anylang-label2
branch
from
84ed57e to
f5650ee
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
=========================================
Coverage 57.62% 57.62%
Complexity 1489 1489
=========================================
Files 32 32
Lines 4170 4170
=========================================
Hits 2403 2403
Misses 1767 1767Continue to review full report at Codecov.
|
|
I looked around in ancient history of the codebase but couldn't find out exactly what happened. In any case, the fix looks sane! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across an edge case where the search language selector button showed as "undefined"
It only seems to happen when
SKOSMOS_SEARCH_LANGcookie has not been setThis PR fixes the issue for me, but please check if it makes sense. My guess is that
[hreflang="anything"]was changed to[hreflang=""]at some point and eventually removed since it's not a valid language code.