Issue617 search by notation

[joelit]

Fixes #617

[codecov]

Codecov Report

Merging #950 into master will increase coverage by 0.04%.
The diff coverage is 68.96%.

@@             Coverage Diff              @@
##             master     #950      +/-   ##
============================================
+ Coverage     57.68%   57.72%   +0.04%     
- Complexity     1489     1496       +7     
============================================
  Files            32       32              
  Lines          4178     4192      +14     
============================================
+ Hits           2410     2420      +10     
- Misses         1768     1772       +4     

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13dee7...92f060c. Read the comment docs.

[joelit]

To test this feature, you need to add skos:searchByNotation "true"; for a vocab with notation codes. You also need set up lucene index for skos:notations (in /etc/fuseki/configuration/ or similar) in the same manner as in tests/fuseki-assembler.ttl, restart fuseki and load the data in the text index before trying it out:

<#entMap> a text:EntityMap ;
text:entityField "uri" ;
text:graphField "graph" ; ## enable graph-specific indexing
text:defaultField "pref" ; ## Must be defined in the text:map
text:uidField "uid" ;
text:langField "lang" ;
text:map (
# skos:prefLabel
[ text:field "pref" ;
text:predicate skos:prefLabel ;
text:analyzer [ a text:LowerCaseKeywordAnalyzer ] ]
# skos:altLabel
[ text:field "alt" ;
text:predicate skos:altLabel ;
text:analyzer [ a text:LowerCaseKeywordAnalyzer ] ]
# skos:hiddenLabel
[ text:field "hidden" ;
text:predicate skos:hiddenLabel ;
text:analyzer [ a text:LowerCaseKeywordAnalyzer ] ]
# skos:notation
[ text:field "notation" ;
text:predicate skos:notation ;
text:analyzer [ a text:LowerCaseKeywordAnalyzer ] ]
) .

[osma]

Some outstanding issues that we just covered face to face:

• in the SPARQL query, the IF clauses for priorities are slightly off, the numbers are overlapping
• the ?blabel variable is bound but never used, it could be dropped
• last but not least, it's probably not a good idea to use an UNION of two kinds of jena-text queries; instead the language parameter should be passed another way

[sonarqubecloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
16 Code Smells

No Coverage information
8.0% Duplication

[joelit]

Some outstanding issues that we just covered face to face:

• in the SPARQL query, the IF clauses for priorities are slightly off, the numbers are overlapping
• the ?blabel variable is bound but never used, it could be dropped
• last but not least, it's probably not a good idea to use an UNION of two kinds of jena-text queries; instead the language parameter should be passed another way

I made the changes and tested the result. However, there should be some further work with how search results are sorted, as I didn't really go through the situation of displaying notation matches before hidden labels matches.

[osma]

As long as performance of search operations doesn't regress badly, looks good to me!