Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust style of the "counts by type" table. #956

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Conversation

osma
Copy link
Member

@osma osma commented Mar 12, 2020

Adds proper CSS styles of the "counts" table on the vocabulary page.
Fixes #955

@osma osma added the bug label Mar 12, 2020
@osma osma added this to the 2.4 milestone Mar 12, 2020
@osma
Copy link
Member Author

osma commented Mar 12, 2020

@tfrancart Does this solve your Arabic RTL issue (#955)?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #956 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #956   +/-   ##
=========================================
  Coverage     58.79%   58.79%           
  Complexity     1505     1505           
=========================================
  Files            32       32           
  Lines          4208     4208           
=========================================
  Hits           2474     2474           
  Misses         1734     1734           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b48bc...2929878. Read the comment docs.

@tfrancart
Copy link
Contributor

Yes it works, thanks !

@osma
Copy link
Member Author

osma commented Mar 12, 2020

Thanks for the quick confirmation @tfrancart !

@osma osma merged commit 11b5f73 into master Mar 12, 2020
@osma osma deleted the issue955-counts-table-css branch March 12, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"counts" table in vocabulary page is missing class="table"
2 participants