Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker files to run self-contained image for trying out Skosmos #962
Add Docker files to run self-contained image for trying out Skosmos #962
Changes from all commits
c1ea002
ab75015
0341ee0
670ba6e
06bc46b
380f57c
bfa048a
4a05865
cc95b85
7d39bc9
53daa92
21614ec
7934a7a
19d6f90
f1a813d
cd23eb4
504880a
6f6d786
9fb69d1
2adf286
b69385c
4f87bd1
6e501b3
8238e3d
d1fdb67
f94b074
ec2d6fc
c99d8bc
e9446b9
10323ad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using port 80 on the host is a bit awkward if you already have, say, Apache listening there (which is normally the case for me). Wasn't there a
-p
option for thedocker run
in an earlier version of this README that mapped the container port 80 to something else? I think it would be better to expose this as e.g. port 9090, as is done in the docker-compose setup.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but not if you want the container to access host URLs like localhost:3030 (localhost being the host not container with skosmos)
There are alternatives though
dockerfiles/config/config-*.ttl
files into a single one)WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, now I see - you have to use
--net=host
to make the container share the host network (so that it can access Fuseki on localhost) instead of sitting on a separate bridged network. So the Apache port inside the container (80) has to match what is seen on the outside, there is no room for a mapping layer.I think this is OK, as long as it's documented - the README has to say that you can't have anything else listening on port 80 (such as Apache).
It should also be possible to switch the Apache in the container to another port by changing the Listen directive, but maybe that's not a great idea since 80 is the expected, standard port number.
I did find a discussion about accessing services on the host which mentioned the possibility of using
host.docker.internal
but apparently this only works on macOS and Windows, and the most recent versions of Docker on Linux (version 20.10.0 released 2020-12-08 included moby/moby#40007). So that could be an option as well, but requires a fairly recent Docker installation - the versions that come pre-packaged with distros are usually older.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly.
Added the following.
I think anyone that wants to deploy Skosmos to AWS/Google/Azure/etc should be able to understand what we did here, and modify the
Dockerfile
and configuration files to match their network/volume/processing requirements.I think we went down the same rabbit hole here 😀 I tried the
host.docker.internal
but that didn't work, then found an issue on github to add it to Linux Docker. We can review it later after new versions of Docker are released, or if a user or dev has feedback on how to improve it I think.Thanks @osma!
Bruno