Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor library dependency updates #997

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

joelit
Copy link
Contributor

@joelit joelit commented Jun 12, 2020

Addresses #918

@joelit joelit requested a review from kouralex June 12, 2020 17:17
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #997 into master will increase coverage by 2.61%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #997      +/-   ##
============================================
+ Coverage     59.12%   61.74%   +2.61%     
- Complexity     1548     1661     +113     
============================================
  Files            32       32              
  Lines          4335     4723     +388     
============================================
+ Hits           2563     2916     +353     
- Misses         1772     1807      +35     
Impacted Files Coverage Δ Complexity Δ
model/Concept.php 82.32% <0.00%> (+2.53%) 239.00% <0.00%> (+52.00%)
model/VocabularyConfig.php 95.62% <0.00%> (+2.55%) 142.00% <0.00%> (+61.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9877c8...6d0ed10. Read the comment docs.

Copy link
Contributor

@kouralex kouralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, except that updating the punic will cause different behavior, I expect. See https://github.com/punic/punic/releases/tag/2.0.0 for more information.

Additionally, one can notice how the listing here changes after this is applied but I guess it is for the better.

@joelit joelit merged commit f0033ad into master Jun 15, 2020
@osma osma added this to the 2.7 milestone Jun 24, 2020
@osma osma deleted the issue918-minor-updates-to-dependecies branch March 11, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants