Convert many Topic overrides to use OnTopic instead #4746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
out-of-phaze
added
the
work in progress
out-of-phaze
force-pushed
the
codequality/ontopic
branch
from
2ad8983 to
829b692
Compare
out-of-phaze
added
ready for review
MistakeNot4892
previously approved these changes
Jan 31, 2025
MistakeNot4892
added
the
has conflicts
fix newscaster ontopic
fix nuke ontopic
out-of-phaze
force-pushed
the
codequality/ontopic
branch
from
829b692 to
9ce3e7b
Compare
MistakeNot4892
removed
the
has conflicts
MistakeNot4892
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
HEAVY WIP. Will probably need testing but that'll be a huge pain with how much this touches, so it might need to be broken up.
Why and what will this PR improve
Overriding Topic instead of OnTopic causes issues with missing parent call functionality and TOPIC_BLAH return values not being respected. This is better.