Fix lighting overlays being created multiple times per turf #4756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MistakeNot4892
approved these changes
Jan 18, 2025
Lohikar
reviewed
Jan 19, 2025
| var/datum/level_data/level = SSmapping.levels_by_z[zlevel] | ||
| for (var/turf/tile as anything in block(1, 1, zlevel, level.level_max_width, level.level_max_height)) // include TRANSITIONEDGE turfs | ||
| if (TURF_IS_DYNAMICALLY_LIT_UNSAFE(tile)) | ||
| tile.lighting_build_overlay() |
There was a problem hiding this comment.
Is using this helper a correctness fix? It was done manually for performance, though this is not particularly hot anyway.
There was a problem hiding this comment.
well, i guess i could copy the CRASH or assert to this loop. mostly i just wanted to make damn well sure nothing was creating an overlay without it also checking to see if it already had one
There was a problem hiding this comment.
It looks like O7 just has logging in this block, I'm fine with either approach assuming calling TBO here doesn't blow out lighting init times (which I assume it doesn't).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes unnecessary/redundant z-level initialization and inlines a method that shouldn't ever be reused elsewhere.
Also re-enables some guard code to prevent this from being reintroduced.
Finally, we always go through lighting_build_overlay to make overlays, rather than just using a bare
new()in SSlighting init.Why and what will this PR improve
Restores some assumptions that O7L uses, potentially optimizes some parts of lighting