Develop bbaepro #352
Merged
Develop bbaepro #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NotOssy/develop-bbaepro # Conflicts: # bbaeAPI.py
Selling support addition with stock held before selling validation.
What needs done before merge
|
|
@NelsonDane This should be ready to be run through and tested by you. As you can see from the checklist above, I tested functionality on all brokerages and I am happy with the functionality and give it my check off. |
NelsonDane
requested changes
Sep 7, 2024
fix quotes, add .get, and check for login success before returning True
|
If this still works for you and yo have no other changes then go ahead and merge @matthew55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OOPS, OLD ONE BROKE.
no longer need to manually install packages, just did pip install -r requirements.txt