Adjust to AbstractAlgebra 0.10 #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support immutables.
|
Should we ignore the nightly failure? |
|
Yes, it was failing before we touched the flint version. |
|
Are there any doc changes needed? |
|
I checked again and it seems no (which is weird). They never mention the |
|
Yeah the Nemo docs are severely abbreviated and just refer to AbstractAlgebra (which I plan to change one day when things have stabilised even more). |
wbhart
approved these changes
Aug 5, 2020
|
Can this be merged then and a new release be made, please? Also: can close #863 |
|
Merging yes. New release? Probably not so quickly. There are other things that I want to adjust (printing). Also I rather wait for the outcome of #862 and see if we need to adjust things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #841.