Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the internal definition of div/divrem in Nemo agree with the internal definition used by AbstractAlgebra (and with Flint).
This allows generic code to run correctly over Nemo.fmpz (e.g. the Generic.Modules test that I added as a regression test).
Fixes #842
Fixes #743 (because it was annoying me)
N.B. This is breaking and should not be merged until we have checked that no other packages break. In any event, at least Hecke.jl and Oscar.jl (and maybe Singular.jl) should import Nemo.div and Nemo.divrem instead of Base.div and Base.divrem, which will likely cause breakage.
I will check this out as soon as possible.