Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the hint according to user keymappings #564

Closed
IndianBoy42 opened this issue Jul 13, 2023 · 4 comments · Fixed by #618
Closed

Modify the hint according to user keymappings #564

IndianBoy42 opened this issue Jul 13, 2023 · 4 comments · Fixed by #618

Comments

@IndianBoy42
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I want to keep 's' to use leap.nvim in the neogit buffer, so i have made a = Stage (mnemonic add)

Describe the solution you'd like
I want to modify the hint at the top of the neogit buffer to say st[a]ge instead. Maybe also add a few other helpful hints. I think this part can be manual, but the ? popup should also be adjusted to include new mappings (it still says s Stage after the above mapping)

@PriceHiller
Copy link
Contributor

With the current way the keymaps are layed out in Neogit this isn't exactly trivial, but it's not hard. If #604 is ok and merged with vim.tbl_add_reverse_lookup then the solution for the hints at the top of the Neogit status buffer are pretty easy to update.

What might be more difficult to set is the help menu bindings in the Neogit status buffer.

@PriceHiller
Copy link
Contributor

Since #604 got merged, I'll see if I can get around to this tomorrow (ideally).

PriceHiller added a commit to PriceHiller/neogit that referenced this issue Jul 15, 2023
PriceHiller added a commit to PriceHiller/neogit that referenced this issue Jul 16, 2023
@PriceHiller
Copy link
Contributor

@CKolkey As a heads up #618 only updates the hint mappings at the top of the buffer, it still does not show the correct keybindings in the help popup.

May want to reopen this or I can create a separate issue for that.

@CKolkey
Copy link
Member

CKolkey commented Jul 16, 2023

Oh, it auto closed since I merged the linked PR. Why don't you make a new issue and we can circle back to it when #601 is merged (assuming conflicts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants