Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add documentation for tests #633

Merged
merged 4 commits into from
Jul 21, 2023
Merged

docs: add documentation for tests #633

merged 4 commits into from
Jul 21, 2023

Conversation

PriceHiller
Copy link
Contributor

Nitpick my writing skills, no holds barred. I'm not an exemplary writer, so if you see something you want changed, just say "change this to x" and I'll make the modification, no need to justify 😃.

Closes #620

@PriceHiller PriceHiller force-pushed the doc/test-documentation branch from 4efbba7 to a2ae230 Compare July 18, 2023 07:40
@ten3roberts ten3roberts self-requested a review July 18, 2023 08:21
CKolkey
CKolkey reviewed Jul 18, 2023
View reviewed changes
tests/README.md Outdated Show resolved Hide resolved
@PriceHiller PriceHiller force-pushed the doc/test-documentation branch from 7ab5bb4 to 09b8df4 Compare July 18, 2023 16:31
ten3roberts
ten3roberts requested changes Jul 21, 2023
View reviewed changes
tests/README.md Show resolved Hide resolved
tests/README.md Show resolved Hide resolved
@PriceHiller PriceHiller force-pushed the doc/test-documentation branch from 09b8df4 to a57a0df Compare July 21, 2023 20:48
@PriceHiller PriceHiller requested a review from ten3roberts July 21, 2023 20:49
@PriceHiller
Copy link
Contributor Author

Updated with the changes requested. Again sorry about the 4 day delay, never saw the notification from my email.

@PriceHiller PriceHiller force-pushed the doc/test-documentation branch from a57a0df to 6efbaa5 Compare July 21, 2023 20:54
ten3roberts
ten3roberts approved these changes Jul 21, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@ten3roberts
Copy link
Member

Updated with the changes requested. Again sorry about the 4 day delay, never saw the notification from my email.

No worries. That happens to all of us. My mailbox has been absolutely flooding and then some more from all different corners of all different programming languages, domains, and chats.

I'm just glad you are offering to help, it is always such a lovely thing in open source.

ten3roberts
ten3roberts approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@ten3roberts ten3roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. We could merge this now if you want to.

If there is anything you discover that is missing in this feel free to open another PR, I figure it is better to merge this so that you don't have to many outstanding PRs generating merge conflicts.

@PriceHiller
Copy link
Contributor Author

Looks great. We could merge this now if you want to.

If there is anything you discover that is missing in this feel free to open another PR, I figure it is better to merge this so that you don't have to many outstanding PRs generating merge conflicts.

Yeah go ahead and merge, I have nothing to add currently and if I do I'll add it in another PR.

@ten3roberts ten3roberts merged commit c8b3b3f into NeogitOrg:master Jul 21, 2023
@PriceHiller PriceHiller deleted the doc/test-documentation branch July 21, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CKolkey CKolkey CKolkey left review comments

@ten3roberts ten3roberts ten3roberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Test Documentation
3 participants
@PriceHiller @ten3roberts @CKolkey