-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
docs: trace-log MUTXO info in wallet-updater
Implement `Display` for `MonitoredUtxo` and trace-log this output in the wallet-state method that updates the wallet state with a new block. This feature was inspired by the bug hunt leading to #328.
- Loading branch information
1 parent
6ffa24b
commit 0bb0086
Showing
2 changed files
with
50 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0bb0086
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: personally, I don't think this is the commit type “docs”. The angular CONTRIBUTING.md says “docs” is for “[d]ocumentation only changes”. Perhaps it's worth to have a commit type “trace”? For this commit specifically, one might even argue the type is “feat(MonitoredUtxo): Implement
Display
”.