neptune-cli and neptune-core might disagree about network
#256
Assignees
Comments
|
I already dealt with this in #185. But it seems those changes were omitted when merging. 😞 The approach taken was to to remove the --network argument. Only the commands that deal with wallet files offline accept a network arg directly. Anything else that requires network knowledge calls node's network RPC, ie |
|
Sorry I didn't catch that when attempting to port #185 to the new transaction logic. |
dan-da
added a commit
that referenced
this issue
Jan 2, 2025
closes #256 small refactor to neptune-cli so that online commands obtain network from neptune-core via rpc and offline commands accept a network arg and optional data-dir arg. This prevents a network mis-match between neptune-cli and neptune-core. also renames own-receiving-address to next-receiving-address. These are some of the changes from pr #185 that were missed in the merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Each of these two programs have a value for
Network. But when the CLI program contacts the RPC server, we don't check that they agree. This could potentially be dangerous.One potential solution is to include the
Networkparameter in all requests to the RPC server, and if the two programs disagree, an error is returned.The text was updated successfully, but these errors were encountered: