chore(deps): Upgrade dependency tasm-lib
#351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sword-Smith
approved these changes
Jan 25, 2025
|
Hold on. Can you check if the hardcoded timelock hash is still valid? There is a test for that, that must pass. |
|
Let's just wait for CI in that case? 😌 |
It'll never finish, i.e. be aborted, if the proofs are not there. |
|
What's been the strategy to get green light from CI in previous PRs? |
|
Have a look at commit 7772861 to see how to update the Feel free to use mjolnir to generate the proofs. |
jan-ferdinand
force-pushed
the
jfs/upgrade_tasm_lib
branch
from
41cb947 to
e0f597d
Compare
|
Beautiful changes. Thanks for a great PR. All tests pass on my local machine. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Sword-Smith, this should be in a decent state now. Opening a PR because merging this will invalidate proofs.