Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(h5): the value called by onThemeChange callback reversed #17313

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

Hitsuki9
Copy link
Contributor

@Hitsuki9 Hitsuki9 commented Feb 12, 2025

这个 PR 做了什么? (简要描述所做更改)

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

This was referenced Feb 15, 2025
@tutuxxx tutuxxx added this to the 4.0.10 milestone Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.52%. Comparing base (1ab7de8) to head (b4d1049).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17313   +/-   ##
=======================================
  Coverage   58.52%   58.52%           
=======================================
  Files         468      468           
  Lines       27136    27136           
  Branches     5921     5898   -23     
=======================================
  Hits        15882    15882           
- Misses       9780     9875   +95     
+ Partials     1474     1379   -95     
Flag Coverage Δ
taro-cli 72.37% <ø> (ø)
taro-runtime 59.87% <ø> (ø)
taro-web 52.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/taro-h5/src/api/base/weapp/app-event.ts 49.03% <ø> (ø)

... and 31 files with indirect coverage changes

@tutuxxx tutuxxx self-assigned this Feb 27, 2025
@tutuxxx tutuxxx merged commit a600ce4 into NervJS:main Feb 28, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants