Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taro.chooseVideo的验证Param中缺少参数补齐 #4685

Merged
merged 3 commits into from
Oct 25, 2019

Conversation

TigerHee
Copy link
Contributor

Taro.chooseVideo的验证Param中缺少参数补齐

这个 PR 做了什么? (简要描述所做更改)

Taro.chooseVideo的验证Param中缺少参数补齐

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用,不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)

其它需要 Reviewer 或社区知晓的内容:

Taro.chooseVideo的验证Param中缺少参数补齐
@Garfield550 Garfield550 self-requested a review October 25, 2019 07:12
更改回调函数的参数类型
@TigerHee TigerHee requested a review from Garfield550 October 25, 2019 07:27
添加GeneralCallbackResult
@Garfield550
Copy link
Collaborator

等待 CI 通过后合并

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants