fix(weapp): 修复 Taro.cloud 部分函数返回错误的类型定义 #5270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield550
approved these changes
Jan 8, 2020
luckyadam
pushed a commit
that referenced
this pull request
Jan 8, 2020
jiangzm
pushed a commit
to jiangzm/taro
that referenced
this pull request
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
目前
Taro.cloud下函数的返回类型有问题, 导致在 typescript 下使用时 ts 会报错, 比如下图原因在于 typing 定义中没有根据传入的参数来决定返回类型, 应当根据传入的
option是否包含success | fail | complete等回调函数决定是否返回void还是promise. 具体的实现参考微信官方提供的类型定义这个 PR 是什么类型? (至少选择一个)
这个 PR 满足以下需求:
这个 PR 涉及以下平台:
其它需要 Reviewer 或社区知晓的内容：