This repository has been archived by the owner on Sep 25, 2023. It is now read-only.
close http server after WebSocketServer.close #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's necessary to do this, or your http server is still running for period of time after you call Processor.close. BTW, I have no effort to PR this problem for three times Orz.
xiecc
added a commit
that referenced
this pull request
Sep 3, 2014
close http server after WebSocketServer.close
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's necessary to do this, or your http server is still running for period of time after you call Processor.close. Set
httpServer = nullwouldn't work. And wsServer.close wouldn't close the http server ( for more please see filenode_modules\ws\lib\WebSocketServer.js : 111).BTW, I have no effort to PR this problem for three times Orz.