Reverts Zone.Identifier #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefromthecrypt
force-pushed
the
adrian.revert-zone-identification
branch
2 times, most recently
from
0d499e8 to
a3b97e9
Compare
`Zone.Identifier` doesn't pull its weight. The only thing it adds beyond `Provider.supportsDuplicateZones`, is that it can indicate a zone id is the same as its name. This isn't enough to warrant the added complexity. see #350
|
NetflixOSS » denominator » denominator-pull-requests #112 SUCCESS |
codefromthecrypt
pushed a commit
that referenced
this pull request
Mar 29, 2015
Reverts Zone.Identifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zone.Identifierdoesn't pull its weight. The only thing it adds beyondProvider.supportsDuplicateZones, is that it can indicate a zone id isthe same as its name. This isn't enough to warrant the added complexity.
see #350