Implementation of Redlock #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsrinivasanNetflix
requested review from
ipapapa,
smukil,
shailesh33,
kishorekasi and
jcacciatore
smukil
reviewed
Jul 7, 2019
dyno-contrib/src/main/java/com/netflix/dyno/contrib/ArchaiusConnectionPoolConfiguration.java
Outdated
Show resolved
Hide resolved
dyno-contrib/src/main/java/com/netflix/dyno/contrib/consul/ConsulHostsSupplier.java
Outdated
Show resolved
Hide resolved
dyno-core/src/main/java/com/netflix/dyno/connectionpool/ConnectionPoolConfiguration.java
Show resolved
Hide resolved
...core/src/main/java/com/netflix/dyno/connectionpool/impl/ConnectionPoolConfigurationImpl.java
Outdated
Show resolved
Hide resolved
dyno-jedis/src/main/java/com/netflix/dyno/jedis/DynoJedisUtils.java
Outdated
Show resolved
Hide resolved
dyno-recipes/src/main/java/com/netflix/dyno/recipes/lock/DynoLockClient.java
Outdated
Show resolved
Hide resolved
dyno-recipes/src/main/java/com/netflix/dyno/recipes/lock/DynoLockClient.java
Outdated
Show resolved
Hide resolved
dyno-recipes/src/main/java/com/netflix/dyno/recipes/lock/DynoLockClient.java
Show resolved
Hide resolved
dyno-recipes/src/main/java/com/netflix/dyno/recipes/lock/DynoLockClient.java
Show resolved
Hide resolved
dyno-recipes/src/main/java/com/netflix/dyno/recipes/lock/DynoLockClient.java
Show resolved
Hide resolved
rsrinivasanNetflix
force-pushed
the
feature/dynoLock
branch
from
2942281 to
39f09af
Compare
jcacciatore
reviewed
Jul 10, 2019
dyno-core/src/main/java/com/netflix/dyno/connectionpool/impl/HostsUpdater.java
Outdated
Show resolved
Hide resolved
smukil
reviewed
Jul 19, 2019
| List<String> racks = numHostsPerRack.keySet().stream().sorted(Comparator.comparing(String::toString)).collect(Collectors.toList()); | ||
| for(String rack: racks) { | ||
| // // Already have required number of hosts for voting. Do not take any more. | ||
| // if(numHostsRequired.get() <= 0) { |
There was a problem hiding this comment.
Should we just remove this commented code?
There was a problem hiding this comment.
good point. this got left behind. will remove.
| AtomicInteger numHostsRequired = new AtomicInteger(effectiveVotingSize); | ||
| // Map to keep track of number of hosts to take for voting from this rack | ||
| Map<String, Integer> numHosts = new HashMap<>(); | ||
| // Sort racks to get the same order |
There was a problem hiding this comment.
Would this work reliably if we have the same rack names across DCs?
There was a problem hiding this comment.
resolved offline
| // continue; | ||
| // } | ||
| // Need more hosts take as as many as you can from this rack. | ||
| int v = (int) Math.min(numHostsRequired.get(), numHostsPerRack.get(rack)); |
There was a problem hiding this comment.
How do we handle the case where we don't have enough voting hosts? Eg: If we just get back one host from this?
There was a problem hiding this comment.
good point. added a check for an edge case.
smukil
approved these changes
Jul 26, 2019
rsrinivasanNetflix
force-pushed
the
feature/dynoLock
branch
from
597038d to
7b25392
Compare
This was referenced Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing redlock in Dyno.
Will add more tests. Starting PR to get some feedback to iterate.