Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating ability to have a custom (non-hostname) instanceId in non-AWS instances #28

Closed
wants to merge 2 commits into from

Conversation

danielkwinsor
Copy link

https://groups.google.com/forum/#!topic/eureka_netflix/Rntihgo1i50

#24

There's no problem with the CI build, it just complains there is no junit test case.

@cloudbees-pull-request-builder

eureka-pull-requests #5 FAILURE
Looks like there's a problem with this pull request

@CH3CHO
Copy link
Contributor

CH3CHO commented Feb 21, 2014

I also would like this pull request to be merged. Is there any other change needed to get it done?

@NiteshKant
Copy link
Contributor

I merged this pull request: #85 recently. Does that suffice? @danielkwinsor unfortunately we have not been able to merge this request before. In the light of the other code change (#85), if you think this is required, can you sync this pull request to the master?

@CH3CHO
Copy link
Contributor

CH3CHO commented Feb 24, 2014

I've looked ino that pull request. If I get it right, it only works for Amazon Data Center, not MyOwn Data Center. Unfortunately, we are using the latter one. So it would be better to have this instance level of configuration.

@NiteshKant
Copy link
Contributor

@CH3CHO if your DatacenterInfo Object implements UniqueIdentifier interface, the id for the instance will be assigned the id returned via getId()

@NiteshKant
Copy link
Contributor

Closing this pull request as it is not required anymore. @CH3CHO let me know if you think otherwise.

@NiteshKant NiteshKant closed this Apr 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants