Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CSR to string #5066

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Convert CSR to string #5066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lemur/plugins/lemur_acme/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
from lemur.dns_providers import service as dns_provider_service
from lemur.exceptions import InvalidConfiguration
from lemur.extensions import metrics

from lemur.plugins import lemur_acme as acme
from lemur.plugins.bases import IssuerPlugin
from lemur.plugins.lemur_acme.acme_handlers import AcmeHandler, AcmeDnsHandler
Expand Down Expand Up @@ -192,7 +191,10 @@ def get_ordered_certificates(self, pending_certs):
self.acme.autodetect_dns_providers(domain)

try:
order = acme_client.new_order(pending_cert.csr)
csr = pending_cert.csr
if isinstance(csr, str):
jtschladen marked this conversation as resolved.
Show resolved Hide resolved
csr = csr.encode("ascii")
order = acme_client.new_order(csr)
except WildcardUnsupportedError:
capture_exception()
metrics.send(
Expand Down
Loading