meson: use library() and fix external builds

[1480c1]

Use library() so the --default-library flag will have an effect, fixes #557 and an issue in #613

also fixes #752

[1480c1]

I guess github actions is updating their stuff

[kylophone]

@1480c1, finally got around to testing this. Sorry for the delay! Can we please keep the vmaf tool statically linked by default? Other than that, I think this looks good. Thanks for the fixes.

[1480c1]

Can we please keep the vmaf tool statically linked by default?

since we are using library() instead of both_libraries(), the object doesn't have a static library associated with it by default, the user would need to choose to create, and thus link, a static library through the --default-library static flag. In the case where they use --default-library both, I believe meson will choose the shared library by default, I am not sure if there's a way to detect if the object returned has a static version in a both scenario and link to it, maybe best that could be done would be to have a different path if default-library is both

[kylophone]

, I believe meson will choose the shared library by default, I am not sure if there's a way to dete

Hmm, I see. I guess just updating the build docs include "use --default-library static if desired" is reasonable. Also we'll want to update this in our CI runners to make sure that the artifacts we're uploading are statically linked.

[1480c1]

I am currently testing a way to detect the default_library option and choosing the static version when applied, do hold before merging

[kylophone]

I am currently testing a way to detect the default_library option and choosing the static version when applied, do hold before merging

Yep, will stand by.

[1480c1]

changing link_with : libvmaf to link_with : get_option('default_library') == 'both' ? libvmaf.get_static_lib() : libvmaf now results with

--default-library	ninja test	libvmaf	ldd libvmaf/build/tools/vmaf
none	OK	.so	/code/vmaf/libvmaf/build/tools/../src/libvmaf.so.1
static	OK	.a	no *vmaf.so*
shared	OK	.so	/code/vmaf/libvmaf/build/tools/../src/libvmaf.so.1
both	OK	.a and .so	no *vmaf.so*

So I guess the only thing left would be, do we want static to be the default option on none, or the current shared?

[1480c1]

I'm going to set the default to doing both to match what we previously had

[1480c1]

@kylophone ready for review

[kylophone]

Alright, I've tested and merged. Thanks for being patient!