This fixes an issue where Zuul does not correctly handle absolute URIs from Netty #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mridgway
approved these changes
Jan 26, 2022
argha-c
approved these changes
Jan 26, 2022
| // absolute uri | ||
| if (m.matches()) { | ||
| String match = m.group(3); | ||
| path = match == null ? uri : match; |
There was a problem hiding this comment.
This doesn't read great. Consider making the assignment explicit on each branch
|
|
||
| // absolute uri | ||
| if (m.matches()) { | ||
| String match = m.group(3); |
There was a problem hiding this comment.
Consider adding an example URI in the comment. 3 reads like a magic number otherwise.
There was a problem hiding this comment.
Added comment at the top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://www.w3.org/Protocols/rfc2616/rfc2616-sec5.html#sec5.1.2 the path segment of an inbound request can have an absolute URI in it. This fixes an issue where Zuul assumes that it's always a relative URI.