Replace PromiseCombiner usage on ClientConnectionsShutdown #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argha-c
approved these changes
Mar 1, 2023
|
|
||
| //racy situation if new connections are still coming in, but any channels created after newCloseFuture will | ||
| //be closed during the force close stage | ||
| ChannelGroupFuture closeFuture = channels.newCloseFuture(); |
| } | ||
| }); | ||
| // Wait for all the attempts to close connections gracefully, or max of 30 secs | ||
| if(closeFuture.await(30, TimeUnit.SECONDS)) { |
There was a problem hiding this comment.
So, this would end up waiting a max of 30s for shutdown across all channels. While it's an improvement, I think it's a change from the existing behavior which waits significantly longer.
Can we make this configurable as we roll this out?
…onto jvm shutdown hook thread. Make force close timeout configurable
gavinbunney
reviewed
Mar 2, 2023
| closeFuture.addListener(future -> { | ||
| if (!timeoutTask.isDone()) { | ||
| //close happened before the timeout | ||
| LOG.info("All connections closed within timeout"); |
gavinbunney
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClientConnectionsShutdown is broken in two different ways
gracefullyShutdownClientChannels()is called as part of a discovery callback, the use ofImmediateEventExecutor.INSTANCEtriggers a deadlock check in netty:I replaced the use of PromiseCombiner with bulk operations on the ChannelGroup, and also added unit tests