run test suite with 'Xcheck:jni' JVM argument #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run the test suite with "check:jni" so that we can detect any crtitical JNI problems
sullis
changed the title
gavinbunney
approved these changes
Jan 27, 2024
argha-c
pushed a commit
that referenced
this pull request
Sep 10, 2024
Run the test suite with "Xcheck:jni" so that we can detect any critical JNI problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should run our testsuite with '-Xcheck:jni' to ensure we catch bugs in JNI code which could later cause issues like crashes
Modifications
Add -Xcheck:jni
Result
Testsuite will be able to catch more JNI bugs
Related work
This PR was inspired by a Netty PR:
netty/netty#13642
Tweet from Norman Maurer (September 2023)
JDK documentation
https://docs.oracle.com/en/java/javase/21/docs/specs/man/java.html