Handle close_notify in ConnectionPoolHandler #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguerra
changed the title
jguerra
requested review from
argha-c,
AlexanderEllis,
lindseyreynolds and
lalernehl
argha-c
approved these changes
Oct 30, 2024
| @@ -55,6 +55,10 @@ public enum OutboundErrorType implements ErrorType { | |||
| ERROR_TYPE_ORIGIN_RESET_CONN_STATUS.get(), | |||
| ZuulStatusCategory.FAILURE_ORIGIN_RESET_CONNECTION, | |||
| ClientException.ErrorType.CONNECT_EXCEPTION), | |||
| CLOSE_NOTIFY_CONNECTION( | |||
| 504, | |||
There was a problem hiding this comment.
nit: This is technically the equivalent of CONNECT_ERROR imo, which maps to a 502 vs 504
| @@ -97,6 +99,11 @@ public void userEventTriggered(ChannelHandlerContext ctx, Object evt) throws Exc | |||
| + reason.name() + ", " + ChannelUtils.channelInfoForLogging(ctx.channel()); | |||
| closeConnection(ctx, msg); | |||
| } | |||
| } else if(evt instanceof SslCloseCompletionEvent event) { | |||
| @@ -58,6 +60,7 @@ public ConnectionPoolHandler(OriginName originName) { | |||
| this.inactiveCounter = SpectatorUtils.newCounter(METRIC_PREFIX + "_inactive", originName.getMetricId()); | |||
| this.errorCounter = SpectatorUtils.newCounter(METRIC_PREFIX + "_error", originName.getMetricId()); | |||
| this.headerCloseCounter = SpectatorUtils.newCounter(METRIC_PREFIX + "_headerClose", originName.getMetricId()); | |||
| this.sslCloseCompletionCounter = SpectatorUtils.newCounter(METRIC_PREFIX + "_sslClose", originName.getMetricId()); | |||
lalernehl
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added a new status category to differentiate this failure from connection resets