Add errorprone and nullaway analysis #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorworley
force-pushed
the
nullaway
branch
from
dfcbc99 to
82df9d8
Compare
connorworley
force-pushed
the
nullaway
branch
from
e5e55af to
ce0e86d
Compare
connorworley
force-pushed
the
nullaway
branch
from
33a883d to
1806ee9
Compare
jguerra
approved these changes
Nov 4, 2024
|
|
||
| @Override | ||
| public boolean equals(Object object) { | ||
| return false; |
There was a problem hiding this comment.
Yeah not sure why this was here, errorprone complains that it doesn't implement hashCode as well but I'm not sure we need it in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently spews a bunch of warnings, which we can reduce over time. At a minimum, new changes should avoid introducing new warnings.