PoC of feature/pipe based on feature/stdin #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will: - Fix mutex locking issues when running multiple demeuk together - Remove temponary file requirements - Simplify codebase by considering files and pipes equal
Appending by default can be highly confusing, overwrite yet safeguard against overwriting existing files
Add visualize of amount of threads being used. This makes clear to the user more threads are possible as config argument
|
Aaah, tried to get the checks to run. But because this is a pull request to a branch they will not run. |
This behavior is similar to all other linux tools like cat & cut
…ase linux tools Only enable verbose entries when you enable logging.
|
There were some issues with the code and some changes which were bit ninja changes. In general I change all log to be disabled. I like this behavior because it is more close to what general Linux tools do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took feature/stdin as inspiration and rewrote parts of to create a true 'pipe' experience. While here did some UI tweaking and safeguarding against errors.