Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcv06 update emitted event #473

Merged
merged 2 commits into from
Nov 22, 2023
Merged

rpcv06 update emitted event #473

merged 2 commits into from
Nov 22, 2023

Conversation

rianhughes
Copy link
Contributor

closes #472

joshklop
joshklop approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@joshklop joshklop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do they need to be omitted sometimes?

@rianhughes
Copy link
Contributor Author

Why do they need to be omitted sometimes?
If it's not classified as "required" then the "omitempty" flag is added
https://github.com/starkware-libs/starknet-specs/blob/v0.6.0-rc1/api/starknet_api_openrpc.json#L924

@rianhughes rianhughes merged commit 7b39d75 into main Nov 22, 2023
3 checks passed
@rianhughes rianhughes deleted the rpcv06-emitted_event branch November 22, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshklop joshklop joshklop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rpcv06 Some Emitted Event files are not required
2 participants
@rianhughes @joshklop