Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests break with h5py>=3.0 #122

Closed
jsosulski opened this issue Dec 11, 2020 · 4 comments
Closed

Tests break with h5py>=3.0 #122

jsosulski opened this issue Dec 11, 2020 · 4 comments
Assignees
@ErikBjare @sylvchev
Labels
bug

Comments

@jsosulski
Copy link
Collaborator

jsosulski commented Dec 11, 2020 •
edited
Loading

I think the issue is probably some package in requirements that had an update between now and the last succesful master build (3 months ago in Travis CI). I do not yet know which package is responsible, but we should/could consider pinning requirements to avoid these issues in the future, e.g., via a requirements.pinned.txt file in addition to requirements.txt.
@jsosulski
Copy link
Collaborator Author

The issue is h5py, with version 2.10, the unit tests work without issues.

I think the issues occurs somewhere in _already_computed in moabb/analysis/results.py but I fear I do not understand the code well enough to find the issue. I do not know when entries would be marked as completed, however, the unit tests fail because a pipeline is marked as already computed when it shouldnt be (I think)

@sylvchev
Copy link
Member

Thank you so much for tracking down the problem! I may fix the CI now. Honestly, I was considering switching to GH actions as it seems very efficient. I did not know if the allocated computing time and memory are more interesting than TravisCI (or CircleCI) ?

This was referenced Dec 18, 2020
Closed
Merged
ErikBjare added a commit that referenced this issue Dec 18, 2020
@ErikBjare
build(deps): version locked h5py due to #122
6dfe46c
@ErikBjare
Copy link
Collaborator

Workaround (version lock) applied in 6dfe46c and merged in #124.

We should probably still fix the underlying issue and support h5py>=3.0, eventually.

@ErikBjare ErikBjare changed the title Unit tests do not complete on current master Tests break with h5py>=3.0 Dec 18, 2020
@sylvchev sylvchev added the bug label Dec 22, 2020
jsosulski pushed a commit to jsosulski/moabb that referenced this issue Jan 14, 2021
@ErikBjare @jsosulski
ci: added basic GitHub Actions config
fdd9f46 
ci: use bash on all OSs

ci: remove ci on 'dev/*' push

build(deps): version locked h5py due to NeuroTechX#122

docs: added GitHub CI badge

fix: fixed LICENSE template (proper detection by licensee)

build(deps): pinned scikit-learn to <0.24 (while waiting for pyriemann fix)
@m2-farzan m2-farzan mentioned this issue Feb 5, 2021
Merged
@sylvchev
Copy link
Member

Closed by PR #138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ErikBjare ErikBjare

@sylvchev sylvchev

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ErikBjare @jsosulski @sylvchev