Support nwb_version as a fixed-length string #1669
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #1668
In #1612 we added support to do version checks on NWB HDF5 files to improve error reporting. The new
nwb_version
function implictly assumed that the attribute was written as a variable-lenght string. This leads to errors for NWB files that may use fixed-length strings instead (see #1668 for detail). This PR updated theNWBHDF5IO.new_version
property to make sure the resulting bytes object is being decoded to a string in case that the attribute was written as a fixed-length bytes.Checklist
flake8
from the source directory.