Add pip check to tox to catch dependency conflicts
#924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion at #921.
It is currently possible for our pinned requirements list to specify a set of packages that are in conflict with each other. (This is because pip install does not fail in this case pypa/pip#775 pypa/pip#988 )
Indeed, right now we have such a conflict (until #923 is merged). So adding this test should cause CI to fail if it is done before 923.
The
pip checkcommand checks for this condition, and fails if there are conflicts. This PR addspip checkto the tox testenv, and also recommends running it when initially writing the requirements files.I am not sure if I put the command in the right place within tox, but I did test that it detects the conflict.