-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main Menu: Add coverflow menu style #314
Main Menu: Add coverflow menu style #314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also please run ./fbt format
i'll look closer (both at this and other open prs) and merge in the coming days, a bit swamped with uni deadlines right now. still, looks very cool, nice work! |
Awesome sounds great @Willy-JL have a good night & happy holidays! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
theres a few small tweaks i would make, just technicalities, but it doesnt let me push to your fork's branch, please enable "allow edits by maintainers" next time, makes it easier :D
regardless, overall looks good, thanks!
@Willy-JL Thanks man! Happy to contribute hopefully I can get some time for more in the future it sure was fun |
@CodyTolene I tried messaging you on Discord but perhaps you don't use it. Would you be open to a tiny change to your coverflow design like this? It refines the corners making them rounded (which is used a lot around the UI) and slightly fixes the spacing between the cards, text, scrollbar and surrounding border. It's no major redesign obviously, and keeps the spirit of your original design. It is your menu (which I like a lot), so it is up to you which is why I'm asking first. BeforeAfter |
This looks so good nice work on it, I really like it! Thanks for pinging me @956MB I love seeing improvements like this. Also I haven't been on Discord in some time, I'll have to check that soon sorry about that. Looking forward to seeing your updates in future firmware! Have a good one |
What's new
For the reviewer