Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main Menu: Add coverflow menu style #314

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

CodyTolene
Copy link
Contributor

@CodyTolene CodyTolene commented Dec 1, 2024

What's new

  • Add support for scaling menu icons (0-100%)
  • Add new menu style: "CoverFlow"

CoverFlow


For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

Copy link
Member

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please run ./fbt format

@Willy-JL
Copy link
Member

Willy-JL commented Dec 2, 2024

i'll look closer (both at this and other open prs) and merge in the coming days, a bit swamped with uni deadlines right now. still, looks very cool, nice work!

@CodyTolene
Copy link
Contributor Author

Awesome sounds great @Willy-JL have a good night & happy holidays!

Copy link
Member

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theres a few small tweaks i would make, just technicalities, but it doesnt let me push to your fork's branch, please enable "allow edits by maintainers" next time, makes it easier :D

regardless, overall looks good, thanks!

@Willy-JL Willy-JL changed the title Add coverflow menu style. Main Menu: Add coverflow menu style Jan 16, 2025
@Willy-JL Willy-JL merged commit 530f3d4 into Next-Flip:dev Jan 16, 2025
@Willy-JL Willy-JL added the feature New feature or request label Jan 16, 2025
Willy-JL added a commit that referenced this pull request Jan 17, 2025
@CodyTolene
Copy link
Contributor Author

@Willy-JL Thanks man! Happy to contribute hopefully I can get some time for more in the future it sure was fun

@956MB
Copy link
Member

956MB commented Mar 1, 2025

@CodyTolene I tried messaging you on Discord but perhaps you don't use it. Would you be open to a tiny change to your coverflow design like this? It refines the corners making them rounded (which is used a lot around the UI) and slightly fixes the spacing between the cards, text, scrollbar and surrounding border. It's no major redesign obviously, and keeps the spirit of your original design. It is your menu (which I like a lot), so it is up to you which is why I'm asking first.

Before

Original

After

Edits

@CodyTolene
Copy link
Contributor Author

This looks so good nice work on it, I really like it!

Thanks for pinging me @956MB I love seeing improvements like this. Also I haven't been on Discord in some time, I'll have to check that soon sorry about that.

Looking forward to seeing your updates in future firmware! Have a good one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants