Archive: Add dynamic paths to browser tab #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought it would be cool to be able to see when I was in say the `apps_data/flipchess` folder, or some other nested folder, and have "flipchess" be shown rather than the just "Browser" all the time. It's not a huge or really crucial change, just a personal modification that some people may also find useful.
956MB
requested review from
Willy-JL,
Sil333033,
HaxSam and
MatthewKuKanich
as code owners
|
missed opportunity for sorry i just had to 😆, i like this idea! will review in the coming days |
AGH! Scrap the whole thing. Kidding, looking forward to it 👍 |
Cleaned up `archive_update_formatted_path` function using switch case, and also using the built in furi functions where possible. Also removed the arbitrary and unnecessary `path_buf[256]`, making formatting the path in the Brief section more memory safe.
956MB
commented
Jan 17, 2025
Willy-JL
requested changes
Jan 17, 2025
|
hmm tho the way i did it makes it not change text while searching. just that the scrollable text text functions need a furistring so i thought to just use the same one as formatted path, but then for searching it needs to change even if the path didnt change. might be easier to just use a temporary furistring, or to use the normal draw function while searching |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Adds to the option to show current directory/path in archive tab instead of static tab text. Default state is
OFFto maintain the existing look, but I personally thinkCurrentcould probably be set as default if merged. Of course all text involedShow Browser Path,Current,BriefandFullcould be changed as well.elements_scrollable_text_lineto allow for full visibility.Gamesare drawn centered like normal, and long ones like/ext/apps/Gamesscroll.Screenshots
"Off"
"Current"
"Brief"
"Full"
For the reviewer