Skip to content

Commit

Permalink
fix(all): 컴포넌트 이름 단축 및 링크 개선
Browse files Browse the repository at this point in the history
- 링크 개선 (접두사 https 추가)
- 컴포넌트 이름 단축
  • Loading branch information
KimHunJin committed Oct 18, 2021
1 parent 187ac14 commit f2ab0ab
Show file tree
Hide file tree
Showing 7 changed files with 31 additions and 24 deletions.
4 changes: 2 additions & 2 deletions components/recruitment/banner.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
<h2 class="bannerSubTitle">{{ subTitle }}</h2>
<p class="bannerPeriod">{{ period }}</p>
<article class="boxArea">
<RecruitmentLinkButton
<LinkButton
v-for="box in boxList"
:key="box.id"
class="box"
:button-name="box.name"
:link="box.link"
:href="`https://${box.link}`"
/>
</article>
</div>
Expand Down
12 changes: 10 additions & 2 deletions components/recruitment/linkButton.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<a class="linkButton" :href="link">{{ buttonName }}</a>
<div class="linkButton" @click="onClick">{{ buttonName }}</div>
</template>

<script>
Expand All @@ -12,11 +12,16 @@ export default defineComponent({
type: String,
require: true,
},
link: {
href: {
type: String,
require: false,
},
},
methods: {
onClick: function () {
location.href = this.href;
},
},
});
</script>

Expand All @@ -36,6 +41,9 @@ export default defineComponent({
background-color: $primary;
color: white;
text-decoration: none;
&:hover {
cursor: pointer;
}
}
@include desktop {
Expand Down
4 changes: 2 additions & 2 deletions components/recruitment/schedule.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
<div class="scheduleArea">
<h2 class="scheduleTitle">모집 일정</h2>
<article class="schedules">
<RecruitmentScheduleBox
class="schedule"
<ScheduleBox
v-for="schedule in schedules"
:key="schedule.id"
class="schedule"
:schedule-title="schedule.title"
:schedule-date="schedule.date"
/>
Expand Down
12 changes: 6 additions & 6 deletions content/recruitment.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,19 +79,19 @@
"result": {
"rawData": [
["버튼명", "클릭 링크", "노출 유무"],
["모집 알림 신청하기", "www.naver.com", "TRUE"],
["디자이너 지원하기", "www.daum.net", "TRUE"],
["개발자 지원하기", "www.google.com", "FALSE"]
["모집 알림 신청하기", "https://www.naver.com", "TRUE"],
["디자이너 지원하기", "https://www.daum.net", "TRUE"],
["개발자 지원하기", "https://www.google.com", "FALSE"]
],
"formatted": [
{ "(A)": "버튼명", "(B)": "클릭 링크", "(C)": "노출 유무" },
{
"(A)": "모집 알림 신청하기",
"(B)": "www.naver.com",
"(B)": "https://www.naver.com",
"(C)": "TRUE"
},
{ "(A)": "디자이너 지원하기", "(B)": "www.daum.net", "(C)": "TRUE" },
{ "(A)": "개발자 지원하기", "(B)": "www.google.com", "(C)": "FALSE" }
{ "(A)": "디자이너 지원하기", "(B)": "https://www.daum.net", "(C)": "TRUE" },
{ "(A)": "개발자 지원하기", "(B)": "https://www.google.com", "(C)": "FALSE" }
],
"header": ["(A)", "(B)", "(C)"],
"range": "'recruitment-banner-button'!A1:Z1000"
Expand Down
3 changes: 3 additions & 0 deletions nuxt.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ const config: NuxtConfig = {
"~/components",
{ path: "~/components/about", extensions: ["vue"] },
{ path: "~/components/project", extensions: ["vue"] },
{ path: "~/components/contact", extensions: ["vue"] },
{ path: "~/components/recruitment", extensions: ["vue"] },
],
content: {
nestedProperties: ["projects.idx"],
Expand All @@ -29,6 +31,7 @@ const config: NuxtConfig = {
"~/assets/css/reset.css",
"~/assets/css/webfont.css",
"~/assets/css/_device.scss",
"~/assets/css/setting.scss",
"~/assets/css/color.scss",
"~/assets/css/typography.scss",
],
Expand Down
2 changes: 1 addition & 1 deletion pages/contact.vue
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<h1 class="header">FAQ</h1>
</div>
<article class="faqArea">
<ContactFaqBox
<FaqBox
v-for="faq in faqs"
:key="faq.idx"
class="faqBox"
Expand Down
18 changes: 7 additions & 11 deletions pages/recruitment.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<transition name="recruitment" mode="out-in">
<div>
<RecruitmentBanner
<Banner
class="banner"
:background-image-url="`https://drive.google.com/uc?export=view&id=${banner.bannerImage}`"
:header-title="banner.bannerTitle"
Expand All @@ -10,30 +10,26 @@
:box-list="bannerBoxes"
/>
<main class="main">
<RecruitmentNoticeBox
<NoticeBox
v-if="notice.isVisible"
:box-title="notice.boxTitle"
:contents="notice.contents"
/>
<RecruitmentDotList
<DotList
class="area"
:dot-list-title="`지원 자격`"
:items="qualifications"
/>
<RecruitmentSchedule class="area" :schedules="schedules" />
<RecruitmentDotList
class="area"
:dot-list-title="`유의사항`"
:items="caution"
/>
<Schedule class="area" :schedules="schedules" />
<DotList class="area" :dot-list-title="`유의사항`" :items="caution" />
</main>
<div class="footer">
<h2 class="footerTitle">궁금한 점이 있으신가요?</h2>
<h3 class="footerSubTitle">자주 묻는 질문을 확인해보세요.</h3>
<RecruitmentLinkButton
<LinkButton
class="faqBox"
:button-name="`FAQ 바로가기`"
:link="`/contact`"
:href="`/contact`"
/>
</div>
</div>
Expand Down

0 comments on commit f2ab0ab

Please sign in to comment.