Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZoneEdit certbot plugin #4208

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

badkeyy
Copy link
Contributor

@badkeyy badkeyy commented Dec 4, 2024

Fixes #4171 without the whitespace issues from #4188.

Credits to #4188 - I hadn’t noticed this PR when I initially added ZoneEdit. Given that it has been a week since the whitespace issues, I decided to move forward and publish my PR to help maintain a faster development cycle.

@badkeyy badkeyy force-pushed the feature/add-zone-edit-certbot-plugin branch from 9551d9d to 1e32280 Compare December 4, 2024 15:47
@kerstenremco
Copy link
Contributor

Thank you! I closed #4188

@jc21
Copy link
Member

jc21 commented Dec 16, 2024

Thanks, but I just need someone to confirm that this works as expected using the test docker image above.

@jc21 jc21 added requires-verification Waiting for one or more people to confirm the fix dns provider request This issue is a request to integrate a new DNS-challenge provider and removed dns provider request This issue is a request to integrate a new DNS-challenge provider labels Dec 16, 2024
@kofal
Copy link

kofal commented Jan 15, 2025

Thanks, but I just need someone to confirm that this works as expected using the test docker image above.

Just tried to initiate a DNS challenge with zoneedit, received the following error:

  
  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [24 lines of output]
      Traceback (most recent call last):
        File "", line 2, in 
        File "", line 14, in 
        File "/opt/certbot/lib/python3.11/site-packages/setuptools/__init__.py", line 8, in 
          import _distutils_hack.override  # noqa: F401
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/opt/certbot/lib/python3.11/site-packages/_distutils_hack/override.py", line 1, in 
          __import__('_distutils_hack').do_override()
        File "/opt/certbot/lib/python3.11/site-packages/_distutils_hack/__init__.py", line 77, in do_override
          ensure_local_distutils()
        File "/opt/certbot/lib/python3.11/site-packages/_distutils_hack/__init__.py", line 63, in ensure_local_distutils
          core = importlib.import_module('distutils.core')
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/usr/lib/python3.11/importlib/__init__.py", line 126, in import_module
          return _bootstrap._gcd_import(name[level:], package, level)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/opt/certbot/lib/python3.11/site-packages/setuptools/_distutils/core.py", line 22, in 
          from .dist import Distribution
        File "/opt/certbot/lib/python3.11/site-packages/setuptools/_distutils/dist.py", line 12, in 
          import logging
        File "/tmp/pip-install-8ufa1uel/logging_2fd8065e510b4e5a956c167160c1ad59/logging/__init__.py", line 618
          raise NotImplementedError, 'emit must be implemented '\
                                   ^
      SyntaxError: invalid syntax
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

    at /app/lib/utils.js:16:13
    at ChildProcess.exithandler (node:child_process:430:5)
    at ChildProcess.emit (node:events:518:28)
    at maybeClose (node:internal/child_process:1104:16)
    at ChildProcess._handle.onexit (node:internal/child_process:304:5)```

@badkeyy
Copy link
Contributor Author

badkeyy commented Jan 15, 2025

Thanks, but I just need someone to confirm that this works as expected using the test docker image above.

Just tried to initiate a DNS challenge with zoneedit, received the following error:

  
  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [24 lines of output]
      Traceback (most recent call last):
        File "", line 2, in 
        File "", line 14, in 
        File "/opt/certbot/lib/python3.11/site-packages/setuptools/__init__.py", line 8, in 
          import _distutils_hack.override  # noqa: F401
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/opt/certbot/lib/python3.11/site-packages/_distutils_hack/override.py", line 1, in 
          __import__('_distutils_hack').do_override()
        File "/opt/certbot/lib/python3.11/site-packages/_distutils_hack/__init__.py", line 77, in do_override
          ensure_local_distutils()
        File "/opt/certbot/lib/python3.11/site-packages/_distutils_hack/__init__.py", line 63, in ensure_local_distutils
          core = importlib.import_module('distutils.core')
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/usr/lib/python3.11/importlib/__init__.py", line 126, in import_module
          return _bootstrap._gcd_import(name[level:], package, level)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/opt/certbot/lib/python3.11/site-packages/setuptools/_distutils/core.py", line 22, in 
          from .dist import Distribution
        File "/opt/certbot/lib/python3.11/site-packages/setuptools/_distutils/dist.py", line 12, in 
          import logging
        File "/tmp/pip-install-8ufa1uel/logging_2fd8065e510b4e5a956c167160c1ad59/logging/__init__.py", line 618
          raise NotImplementedError, 'emit must be implemented '\
                                   ^
      SyntaxError: invalid syntax
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

    at /app/lib/utils.js:16:13
    at ChildProcess.exithandler (node:child_process:430:5)
    at ChildProcess.emit (node:events:518:28)
    at maybeClose (node:internal/child_process:1104:16)
    at ChildProcess._handle.onexit (node:internal/child_process:304:5)```

Hey, thanks for testing. I think I fixed the error could you please try again?

@nginxproxymanagerci
Copy link

Docker Image for build 4 is available on
DockerHub
as nginxproxymanager/nginx-proxy-manager-dev:pr-4208

Note: ensure you backup your NPM instance before testing this image! Especially if there are database changes
Note: this is a different docker image namespace than the official image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires-verification Waiting for one or more people to confirm the fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZoneEdit - DNS challenge provider request
4 participants