Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL Certificates: Show if cert is in use on host (and if host is disabled or enabled) #4244

Conversation

badkeyy
Copy link
Contributor

@badkeyy badkeyy commented Dec 18, 2024

Issue

Fixes #4221

Description:

This PR enhances the SSL Certificates list by adding a Status indicator, indicating if a SSL Certificate is in use on a proxy host or not. If it is in use the domain names for which it is in use on are shown in the dropdown menu of the list item.

Screenshots

image
image

@badkeyy badkeyy marked this pull request as ready for review January 8, 2025 04:43
@badkeyy badkeyy marked this pull request as draft January 9, 2025 18:05
@badkeyy
Copy link
Contributor Author

badkeyy commented Jan 9, 2025

Sorry for setting the status of this PR back to Draft but I noticed that I forgot to implement this feature for dead_hosts and redirection_hosts

@badkeyy badkeyy marked this pull request as ready for review January 9, 2025 22:51
@nginxproxymanagerci
Copy link

CI Error:

/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
certbot-node: Pulling from nginxproxymanager/nginx-full
Digest: sha256:4b9fa6900ddef28e7e52ec9e0395c451731efa5f91a6e0815ae674159b505058
Status: Image is up to date for nginxproxymanager/nginx-full:certbot-node
docker.io/nginxproxymanager/nginx-full:certbot-node
�[1;34m❯ �[1;36mTesting backend ...�[0m
yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > @apidevtools/[email protected]" has unmet peer dependency "openapi-types@>=7".
[4/4] Building fresh packages...
Done in 37.79s.
yarn run v1.22.22
$ /app/node_modules/.bin/eslint .

/app/models/certificate.js
  70:3  error  This group of assignments is not aligned  align-assignments/align-assignments

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@badkeyy badkeyy closed this Jan 10, 2025
@badkeyy badkeyy force-pushed the feature/show-active-host-in-cert-list branch from cf859d2 to fcf4117 Compare January 10, 2025 04:04
@badkeyy badkeyy reopened this Jan 10, 2025
@badkeyy badkeyy force-pushed the feature/show-active-host-in-cert-list branch from 69f7920 to 080bd0b Compare January 10, 2025 04:17
@badkeyy badkeyy closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSL Certificates show if cert is in use on host (and if host is disabled or enabled)
1 participant