Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort tokens in join pool to avoid panic #1110

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Conversation

matthiasmatt
Copy link
Contributor

Description

Join pool for unsorted token generate a panic and it should not be up to the user to sort them in the transaction.

found in py-sdk with:

nibiru.msg.MsgJoinPool(
                sender=agent.address,
                pool_id=pool_ids["uusdc:unusd"],
                tokens=[Coin(100, "uusdc"), Coin(100, "unusd")],
            ),

Purpose

QoL

@matthiasmatt matthiasmatt requested a review from a team as a code owner December 5, 2022 22:29
@Unique-Divine Unique-Divine merged commit 8f11013 into master Dec 6, 2022
@Unique-Divine Unique-Divine deleted the mat/fix-dex-issue branch December 6, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants