feat: improve math for single asset join #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NibiruHeisenberg
suggested changes
Dec 12, 2022
Co-authored-by: NibiruHeisenberg <[email protected]>
Co-authored-by: NibiruHeisenberg <[email protected]>
NibiruHeisenberg
approved these changes
Dec 13, 2022
NibiruHeisenberg
dismissed
Unique-Divine’s stale review
changes were addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@NibiruHeisenberg came up with an easier way to compute the single asset join while at the same time allow for swap fee to be computed: https://www.notion.so/nibiru/Single-Asset-Join-Math-2075178cb9684062b9b65ad23ff14417.
Basically, instead of swapping then joining, we join the pool and then do a single asset join.
This PR migrate the existing single asset join/imbalance join to the new method.
We leverage the uint256 library to do multiplication since we are computing the square of the pool liquidity, which considering the 1e6 precision we use quickly become a very big number (>>int64).
Purpose
Why is this PR important?