Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(make): put Makefile workflows in separate directory #1138

Merged
merged 5 commits into from
Jan 12, 2023
Merged

refactor(make): put Makefile workflows in separate directory #1138

merged 5 commits into from
Jan 12, 2023

Conversation

k-yang
Copy link
Member

@k-yang k-yang commented Jan 11, 2023

Description

Puts the Makefile workflows in the contrib/make directory.

It also fixes some issues with existing outdated build workflows.

Purpose

Clean up our build workflows.

@k-yang k-yang requested a review from a team as a code owner January 11, 2023 18:50
@k-yang k-yang self-assigned this Jan 11, 2023
@k-yang k-yang enabled auto-merge (squash) January 11, 2023 18:50
matthiasmatt
matthiasmatt approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@matthiasmatt matthiasmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner!

@k-yang k-yang merged commit 29f6561 into master Jan 12, 2023
@k-yang k-yang deleted the chore/build-workflows branch January 12, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasmatt matthiasmatt matthiasmatt approved these changes

Assignees

@k-yang k-yang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-yang @matthiasmatt