Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(perp): Organize Keeper methods #684

Merged
merged 7 commits into from
Jul 8, 2022
Merged

refactor(perp): Organize Keeper methods #684

merged 7 commits into from
Jul 8, 2022

Conversation

NibiruHeisenberg
Copy link
Contributor

@NibiruHeisenberg NibiruHeisenberg commented Jul 7, 2022 •
edited
Loading

  • organized Keeper methods more intuitively
  • removes a lot of unnecessary code
  • general code hygiene
  • move GetPositionNotional and GetLatestCumulativePremiumFraction to margin.go

@NibiruHeisenberg NibiruHeisenberg requested a review from a team as a code owner July 7, 2022 20:51
@NibiruHeisenberg NibiruHeisenberg self-assigned this Jul 7, 2022
testinginprod
testinginprod approved these changes Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@testinginprod testinginprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AgentSmithMatrix
Copy link
Contributor

Can you add a CHANGELOG entry?

@NibiruHeisenberg NibiruHeisenberg merged commit 28eb87e into master Jul 8, 2022
@NibiruHeisenberg NibiruHeisenberg deleted the refactor/perp/organize-functions branch July 8, 2022 15:57
@NibiruHeisenberg NibiruHeisenberg restored the refactor/perp/organize-functions branch July 12, 2022 20:24
@NibiruHeisenberg NibiruHeisenberg deleted the refactor/perp/organize-functions branch July 12, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testinginprod testinginprod testinginprod approved these changes

Assignees

@NibiruHeisenberg NibiruHeisenberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NibiruHeisenberg @AgentSmithMatrix @testinginprod