Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(perp): Emit PositionChangedEvent when changing position margin #687

Merged
merged 8 commits into from
Jul 8, 2022
Merged

feat(perp): Emit PositionChangedEvent when changing position margin #687

merged 8 commits into from
Jul 8, 2022

Conversation

NibiruHeisenberg
Copy link
Contributor

  • emit PositionChangedEvent on AddMargin
  • emit PositionChangedEvent on RemoveMargin
  • remove MarginChangedEvent
  • add test coverage
  • removed unnecessary logger debug statements
  • general cleanup

@NibiruHeisenberg NibiruHeisenberg requested a review from a team as a code owner July 8, 2022 17:30
@NibiruHeisenberg NibiruHeisenberg linked an issue Jul 8, 2022 that may be closed by this pull request
refactor(perp): Replace MarginChangedEvent with PositionChangedEvent #637
Closed
@NibiruHeisenberg NibiruHeisenberg self-assigned this Jul 8, 2022
AgentSmithMatrix
AgentSmithMatrix reviewed Jul 8, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@AgentSmithMatrix AgentSmithMatrix merged commit b080568 into master Jul 8, 2022
@AgentSmithMatrix AgentSmithMatrix deleted the refactor/perp/637/margin-changed-event branch July 8, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgentSmithMatrix AgentSmithMatrix AgentSmithMatrix approved these changes

Assignees

@NibiruHeisenberg NibiruHeisenberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(perp): Replace MarginChangedEvent with PositionChangedEvent
2 participants
@NibiruHeisenberg @AgentSmithMatrix