Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vpool): Fluctuation limit check #707

Merged
merged 10 commits into from
Jul 17, 2022

Conversation

NibiruHeisenberg
Copy link
Contributor

@NibiruHeisenberg NibiruHeisenberg commented Jul 16, 2022

  • add fluctuation limit check parameter to vpool keeper's SwapQuoteForBase and SwapBaseForQuote methods
  • add test coverage for fluctuation limit checks
  • add skipFluctuationCheck parameter to perp's vpool keeper interface
  • generate mocks
  • add test coverage on SwapQuoteForBase and SwapBaseForQuote

The PR looks really big but in fact, most of the line changes are from adding missing test coverage.

Follow-up items:

  • implement fluctuation limit checks in perp clearinghouse methods when altering positions
    • right now, everything defaults to skipFluctuationLimitCheck=false except for partial liquidations

@NibiruHeisenberg NibiruHeisenberg requested a review from a team as a code owner July 16, 2022 17:56
@NibiruHeisenberg NibiruHeisenberg changed the title feat(perp): Fluctuation limit check feat(vpool): Fluctuation limit check Jul 16, 2022
@NibiruHeisenberg NibiruHeisenberg linked an issue Jul 16, 2022 that may be closed by this pull request
5 tasks
@NibiruHeisenberg NibiruHeisenberg self-assigned this Jul 16, 2022
@NibiruHeisenberg NibiruHeisenberg added epic Project or large task that groups multiple tickets and PRs tests labels Jul 16, 2022
@Unique-Divine Unique-Divine merged commit 8ed24c2 into master Jul 17, 2022
@Unique-Divine Unique-Divine deleted the feat/perp/fluctuation-limit-check branch July 17, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Project or large task that groups multiple tickets and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(vpool): implement fluctuation limit checks in vpool keeper methods
2 participants