Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vpool): create pools gov handler #725

Merged
merged 17 commits into from
Jul 26, 2022
Merged

feat(vpool): create pools gov handler #725

merged 17 commits into from
Jul 26, 2022

Conversation

testinginprod
Copy link
Collaborator

No description provided.

@testinginprod testinginprod requested a review from a team as a code owner July 21, 2022 17:19
@testinginprod testinginprod mentioned this pull request Jul 21, 2022
Closed
@testinginprod testinginprod changed the title feature(vpool): create pools gov handler feat(vpool): create pools gov handler Jul 21, 2022
@AgentSmithMatrix
Copy link
Contributor

This cannot be merged without testing.

AgentSmithMatrix
AgentSmithMatrix suggested changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@AgentSmithMatrix AgentSmithMatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests

@NibiruHeisenberg
Copy link
Contributor

This cannot be merged without testing.

Yes, please add CLI tests.

NibiruHeisenberg
NibiruHeisenberg reviewed Jul 25, 2022
View reviewed changes
x/vpool/types/gov.go Outdated Show resolved Hide resolved
x/vpool/types/gov.go Outdated Show resolved Hide resolved
x/vpool/types/gov.go Outdated Show resolved Hide resolved
x/vpool/types/gov.go Outdated Show resolved Hide resolved
x/vpool/types/gov.go Outdated Show resolved Hide resolved
x/vpool/types/gov.go Outdated Show resolved Hide resolved
x/vpool/handler.go Outdated
m.FluctuationLimitRatio,
m.MaxOracleSpreadRatio,
)
// TODO(mercilex): oracle missing, pool should not be tradeable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the oracle part too? Otherwise, it's an incomplete feature.

Also if you're going to check in TODOs, please create and attach a GH issue instead of a name so that we can attach context to the TODO.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened a separate issue for this, plus this problem does not relate to gov proposals specifically, it's about vpool itself, if a pricefeed stops posting prices then vpool would still allow trades, which from my understanding is incorrect.

x/vpool/handler.go Show resolved Hide resolved
x/vpool/client/cli/cli_test.go Show resolved Hide resolved
@testinginprod testinginprod merged commit fc10055 into master Jul 26, 2022
@testinginprod testinginprod deleted the mercilex/vpool-new-markets branch July 26, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NibiruHeisenberg NibiruHeisenberg NibiruHeisenberg left review comments

@AgentSmithMatrix AgentSmithMatrix AgentSmithMatrix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@testinginprod @AgentSmithMatrix @NibiruHeisenberg