Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(params): Clean up params for testnet #741

Merged
merged 12 commits into from
Jul 26, 2022
Merged

chore(params): Clean up params for testnet #741

merged 12 commits into from
Jul 26, 2022

Conversation

NibiruHeisenberg
Copy link
Contributor

@NibiruHeisenberg NibiruHeisenberg commented Jul 26, 2022 •
edited
Loading

  • remove stake and test denom
  • remove unused variables
  • refactored names for easier readability
  • name the axlbtc and axlweth denoms
  • rename perp's epoch_identifier param to funding_rate_interval

@NibiruHeisenberg NibiruHeisenberg requested a review from a team as a code owner July 26, 2022 04:46
@NibiruHeisenberg NibiruHeisenberg changed the title chore(params): Configure default params for testnet chore(params): Clean up params for testnet Jul 26, 2022
@NibiruHeisenberg NibiruHeisenberg self-assigned this Jul 26, 2022
@NibiruHeisenberg NibiruHeisenberg added this to the Restricted Testnet milestone Jul 26, 2022
@NibiruHeisenberg NibiruHeisenberg linked an issue Jul 26, 2022 that may be closed by this pull request
chore(perp): define reasonable default genesis values for testnet trading #713
Closed
@testinginprod testinginprod self-requested a review July 26, 2022 09:13
testinginprod
testinginprod approved these changes Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@testinginprod testinginprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There's one dex simulation test failing with regards to invalid pool setup.

@NibiruHeisenberg NibiruHeisenberg merged commit dc3c6c9 into master Jul 26, 2022
@NibiruHeisenberg NibiruHeisenberg deleted the chore/testnet-params branch July 26, 2022 17:56
@NibiruHeisenberg NibiruHeisenberg linked an issue Jul 27, 2022 that may be closed by this pull request
chore: Remove any dependencies on the "stake" denom #582
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testinginprod testinginprod testinginprod approved these changes

@AgentSmithMatrix AgentSmithMatrix AgentSmithMatrix approved these changes

Assignees

@NibiruHeisenberg NibiruHeisenberg

Labels
None yet
Projects
None yet
Milestone
Restricted Testnet
3 participants
@NibiruHeisenberg @AgentSmithMatrix @testinginprod