feat(vpool): Add check for maximum leverage for open positions #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasmatt
changed the title
AgentSmithMatrix
approved these changes
Aug 5, 2022
AgentSmithMatrix
approved these changes
Aug 5, 2022
x/perp/keeper/msg_server_test.go
Outdated
| app.VpoolKeeper.CreatePool( | ||
| ctx, | ||
| common.PairBTCStable, | ||
| sdk.OneDec(), |
There was a problem hiding this comment.
(nit) would be nice to add argument comments for the other parameters too.
x/vpool/types/gov.go
Outdated
| @@ -66,5 +66,13 @@ func (m *CreatePoolProposal) ValidateBasic() error { | |||
| return fmt.Errorf("maintenance margin ratio ratio must be 0 <= ratio <= 1") | |||
| } | |||
|
|
|||
| if m.MaxLeverage.LT(sdk.OneDec()) { | |||
| return fmt.Errorf("Max leverage must be >= 1") | |||
There was a problem hiding this comment.
Wouldn't it be possible for users to open positions with < 1 leverage? They would essentially be opening an over-collateralized position because they maybe think the asset will fluctuate a lot in the short term, but long term will move in their position favorably.
There was a problem hiding this comment.
I'll leave that as a behavior, i think it causes no harm to let the user open those positions
|
Can you check the integration tests? They seem to have failed for this PR. |
NibiruHeisenberg
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #781
tasks: